Update Oasis Emerald Testnet symbol #6086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match official Oasis docs: https://github.com/oasisprotocol/docs/blob/afc1f64/src/AddToMetaMask.tsx#L90-L94
|
You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review. |
ligi
approved these changes
Oct 28, 2024
|
PR merged - please consider contributing some funds to lists.eth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match official Oasis docs:
https://github.com/oasisprotocol/docs/blob/afc1f64/src/AddToMetaMask.tsx#L90-L94
This also matches how Oasis Sapphire symbol is named:
chains/_data/chains/eip155-23294.json
Lines 8 to 10 in 7cbf777
chains/_data/chains/eip155-23295.json
Lines 11 to 13 in 7cbf777
cc @matevz